Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/2684
Thanks for your contribution @tfournier314.
I'm wondering whether we should introduce a new `EvaluateDataSetOperation`
for the special case of a `LabeledVector`. Can't you easily achieve the same by
`val evaluateDS = labeledVectorDS.map(x => (x.vector, x.label))` and then using
`evaluateDS` for the `evaluate` operation?
In general I think it would be better to write a generic
`EvaluateDataSetOperation` which can take a `ValueExtractor` which can extract
the value from the `Testing` type. Then we could offer a `ValueExtractor` for
the `LabeledVector`. That way we could extend it easily for different types as
well.
A general remark: It's always helpful to write a PR description and format
the title according to the contribution guidelines [1]. Furthermore, your code
does not adhere to the existing code style. Even though Flink does not have a
strict code style, it is always good to stick to the code style of the existing
code.
[1] http://flink.apache.org/how-to-contribute.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
