XComp commented on code in PR #22341:
URL: https://github.com/apache/flink/pull/22341#discussion_r1299741764
##########
flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMasterServiceLeadershipRunner.java:
##########
Review Comment:
The `JobMasterServiceLeadershipRunner` change in 042459fa should be moved
into FLINK-27204 commit (042459fa).
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -515,7 +516,7 @@ public CompletableFuture<Acknowledge> submitJob(JobGraph
jobGraph, Time timeout)
log.info("Received JobGraph submission '{}' ({}).",
jobGraph.getName(), jobID);
try {
- if (isInGloballyTerminalState(jobID)) {
+ if (isInGloballyTerminalState(jobID).get()) {
Review Comment:
oh, I missed that one. Sorry. Can we switch to async processing here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
