[
https://issues.apache.org/jira/browse/FLINK-32906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17757617#comment-17757617
]
Jing Ge commented on FLINK-32906:
---------------------------------
[~liyubin117] Thanks for testing.
"but use specified sql-client.display.max-column-width, the configuration also
take effects, it seems conflict with expected `No effect`" - the description
was wrong. "No effect" was a bug and has been fixed alongside the PR. I have
updated the description. Please check it again.
"use specified table.display.max-column-width, the configuration take no
effect, it conflicts with 'Text longer than the value will be truncated and
replaced with “...”'." - this task offers a backward compatible solution and
deprecated sql-client.display.max-column-width, which means once
sql-client.display.max-column-width is used, it falls into the old scenario
where table.display.max-column-width didn't exist, any changes of
table.display.max-column-width won't take effect. You should test it either by
only using table.display.max-column-width or by using
sql-client.display.max-column-width, but not both of them back and forth.
> Release Testing: Verify FLINK-30025 Unified the max display column width for
> SqlClient and Table APi in both Streaming and Batch execMode
> -----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: FLINK-32906
> URL: https://issues.apache.org/jira/browse/FLINK-32906
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Reporter: Jing Ge
> Assignee: Yubin Li
> Priority: Major
> Fix For: 1.18.0
>
> Attachments: image-2023-08-22-18-54-45-122.png,
> image-2023-08-22-18-54-57-699.png, image-2023-08-22-18-58-11-241.png,
> image-2023-08-22-18-58-20-509.png, image-2023-08-22-19-04-49-344.png,
> image-2023-08-22-19-06-49-335.png
>
>
> more info could be found at
> FLIP-279
> [https://cwiki.apache.org/confluence/display/FLINK/FLIP-279+Unified+the+max+display+column+width+for+SqlClient+and+Table+APi+in+both+Streaming+and+Batch+execMode]
>
> Tests:
> Both configs could be set with new value and following behaviours are
> expected :
> | | |sql-client.display.max-column-width, default value is
> 30|table.display.max-column-width, default value is 30|
> |sqlclient|Streaming|text longer than the value will be truncated and
> replaced with “...”|Text longer than the value will be truncated and replaced
> with “...”|
> |sqlclient|Batch|text longer than the value will be truncated and replaced
> with “...”|Text longer than the value will be truncated and replaced with
> “...”|
> |Table API|Streaming|No effect.
> table.display.max-column-width with the default value 30 will be used|Text
> longer than the value will be truncated and replaced with “...”|
> |Table API|Batch|No effect.
> table.display.max-column-width with the default value 30 will be used|Text
> longer than the value will be truncated and replaced with “...”|
>
> Please pay attention that this task offers a backward compatible solution and
> deprecated sql-client.display.max-column-width, which means once
> sql-client.display.max-column-width is used, it falls into the old scenario
> where table.display.max-column-width didn't exist, any changes of
> table.display.max-column-width won't take effect. You should test it either
> by only using table.display.max-column-width or by using
> sql-client.display.max-column-width, but not both of them back and forth.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
