lincoln-lil commented on code in PR #23214:
URL: https://github.com/apache/flink/pull/23214#discussion_r1302565083
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/connector/source/lookup/cache/trigger/PeriodicCacheReloadTrigger.java:
##########
@@ -128,6 +131,7 @@ public static PeriodicCacheReloadTrigger
fromConfig(ReadableConfig config) {
* ScheduledExecutorService#scheduleWithFixedDelay(Runnable, long, long,
TimeUnit) and {@link
* ScheduledExecutorService#scheduleAtFixedRate(Runnable, long, long,
TimeUnit)}}.
*/
+ @Internal
Review Comment:
should be `PublicEvolving`? (checked the flip doc and
https://docs.google.com/spreadsheets/d/1e8M0tUtKkZXEd8rCZtZ0C6Ty9QkNaPySsrCgz0vEID4/edit)
##########
flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/TableApiRules.java:
##########
@@ -39,6 +48,10 @@
/** Rules for Table API. */
public class TableApiRules {
+
+ private static final Pattern TABLE_API_MODULES =
+
Pattern.compile(".*/flink-table-(api-java|api-java-bridge|common)/.*");
Review Comment:
Should we consider 'flink-table-api-java-bridge-base' as well? (although it
wasn't explicitly included in the discussion thread)
##########
flink-architecture-tests/flink-architecture-tests-production/src/main/java/org/apache/flink/architecture/rules/TableApiRules.java:
##########
@@ -39,6 +48,10 @@
/** Rules for Table API. */
public class TableApiRules {
+
+ private static final Pattern TABLE_API_MODULES =
+
Pattern.compile(".*/flink-table-(api-java|api-java-bridge|common)/.*");
Review Comment:
Should we consider 'flink-table-api-java-bridge-base' as well? (although it
wasn't explicitly included in the discussion thread)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
