[ 
https://issues.apache.org/jira/browse/FLINK-32948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17758111#comment-17758111
 ] 

Rui Fan commented on FLINK-32948:
---------------------------------

Looks make sense to me, and assigned to you, please go ahead! :)

> Minimize visibility of parameterized tests
> ------------------------------------------
>
>                 Key: FLINK-32948
>                 URL: https://issues.apache.org/jira/browse/FLINK-32948
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 1.17.1
>            Reporter: Jiabao Sun
>            Assignee: Jiabao Sun
>            Priority: Major
>
> Since  was [FLINK-32942|https://issues.apache.org/jira/browse/FLINK-32942] 
> was merged into master, we can minimize visibility of parameterized tests.
> Before
> {code:java}
> @ExtendWith(ParameterizedTestExtension.class)
> public class ParameterizedTestExtensionTest {
>     private static final List<Integer> PARAMETERS = Arrays.asList(1, 2);
>     @Parameter
>     public Integer parameter;
>     @Parameters
>     public static List<Integer> parameters() {
>         return PARAMETERS;
>     }
>     @TestTemplate
>     void testWithParameters() {
>         assertThat(parameter).isIn(PARAMETERS);
>     }
> }
> {code}
> Now
> {code:java}
> @ExtendWith(ParameterizedTestExtension.class)
> class ParameterizedTestExtensionTest {
>     private static final List<Integer> PARAMETERS = Arrays.asList(1, 2);
>     @Parameter
>     private Integer parameter;
>     @Parameters
>     private static List<Integer> parameters() {
>         return PARAMETERS;
>     }
>     @TestTemplate
>     void testWithParameters() {
>         assertThat(parameter).isIn(PARAMETERS);
>     }
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to