afedulov commented on code in PR #656:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/656#discussion_r1304642225
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -298,37 +298,26 @@ public static String operatorConfigKey(String key) {
+ "Expected format:
headerKey1:headerValue1,headerKey2:headerValue2.");
@Documentation.Section(SECTION_DYNAMIC)
- public static final ConfigOption<Duration> PERIODIC_SAVEPOINT_INTERVAL =
+ public static final ConfigOption<String> PERIODIC_SAVEPOINT_INTERVAL =
operatorConfig("periodic.savepoint.interval")
- .durationType()
- .defaultValue(Duration.ZERO)
+ .stringType()
+ .defaultValue("")
.withDescription(
- "Interval at which periodic savepoints will be
triggered. "
+ "Option to enable automatic savepoint triggering.
Can be specified "
+ + "either as a Duration type (i.e. '10m')
or as a cron expression."
Review Comment:
Added a link to Quartz cron syntax.
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/config/KubernetesOperatorConfigOptions.java:
##########
@@ -298,37 +298,26 @@ public static String operatorConfigKey(String key) {
+ "Expected format:
headerKey1:headerValue1,headerKey2:headerValue2.");
@Documentation.Section(SECTION_DYNAMIC)
- public static final ConfigOption<Duration> PERIODIC_SAVEPOINT_INTERVAL =
+ public static final ConfigOption<String> PERIODIC_SAVEPOINT_INTERVAL =
operatorConfig("periodic.savepoint.interval")
- .durationType()
- .defaultValue(Duration.ZERO)
+ .stringType()
+ .defaultValue("")
.withDescription(
- "Interval at which periodic savepoints will be
triggered. "
+ "Option to enable automatic savepoint triggering.
Can be specified "
+ + "either as a Duration type (i.e. '10m')
or as a cron expression."
+ "The triggering schedule is not
guaranteed, savepoints will be "
+ "triggered as part of the regular
reconcile loop. "
+ "WARNING: not intended to be used
together with the cron-based "
+ "periodic savepoint triggering");
@Documentation.Section(SECTION_DYNAMIC)
- public static final ConfigOption<String> PERIODIC_SAVEPOINT_CRON =
- operatorConfig("periodic.savepoint.cron")
- .stringType()
- .defaultValue(
- "0 0 0 29 2 ? 1999") // Default value that is
guaranteed not to trigger
- .withDescription(
- "A cron expression that defines when to
automatically trigger savepoints."
- + "The precise triggering schedule is not
guaranteed, savepoints will be "
- + "triggered as part of the regular
reconcile loop. "
- + "WARNING: not intended to be used
together with the interval-based "
- + "periodic savepoint triggering");
-
- @Documentation.Section(SECTION_DYNAMIC)
- public static final ConfigOption<Duration> PERIODIC_CHECKPOINT_INTERVAL =
+ public static final ConfigOption<String> PERIODIC_CHECKPOINT_INTERVAL =
operatorConfig("periodic.checkpoint.interval")
- .durationType()
- .defaultValue(Duration.ZERO)
+ .stringType()
+ .defaultValue("")
.withDescription(
- "Interval at which periodic checkpoints will be
triggered. "
+ "Option to enable automatic checkpoint triggering.
Can be specified "
+ + "either as a Duration type (i.e. '10m')
or as a cron expression."
Review Comment:
Added a link to Quartz cron syntax.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
