masteryhx commented on code in PR #21410:
URL: https://github.com/apache/flink/pull/21410#discussion_r1306881957
##########
flink-state-backends/flink-statebackend-changelog/src/test/java/org/apache/flink/state/changelog/ChangelogDelegateEmbeddedRocksDBStateBackendTest.java:
##########
@@ -33,22 +33,21 @@
import org.apache.flink.runtime.state.StateBackend;
import org.apache.flink.runtime.state.TestTaskStateManager;
-import org.junit.Ignore;
-import org.junit.Rule;
-import org.junit.Test;
-import org.junit.rules.TemporaryFolder;
+import org.junit.jupiter.api.Disabled;
+import org.junit.jupiter.api.TestTemplate;
+import org.junit.jupiter.api.io.TempDir;
+import java.io.File;
import java.io.IOException;
/** Tests for {@link ChangelogStateBackend} delegating {@link
EmbeddedRocksDBStateBackend}. */
-public class ChangelogDelegateEmbeddedRocksDBStateBackendTest
- extends EmbeddedRocksDBStateBackendTest {
+class ChangelogDelegateEmbeddedRocksDBStateBackendTest extends
EmbeddedRocksDBStateBackendTest {
- @Rule public final TemporaryFolder temp = new TemporaryFolder();
+ @TempDir static File tmPath;
Review Comment:
```suggestion
@TempDir static File tempFile;
```
##########
flink-state-backends/flink-statebackend-changelog/src/main/java/org/apache/flink/state/changelog/ChangelogMapState.java:
##########
@@ -83,6 +84,16 @@ public UV setValue(UV value) {
}
return oldValue;
}
+
+ @Override
+ public boolean equals(Object o) {
Review Comment:
This fix should not be related to Junit5 migration, right?
It's better to seprate them into 2 commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
