masteryhx commented on code in PR #23298:
URL: https://github.com/apache/flink/pull/23298#discussion_r1306888876
##########
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendMigrationTestBase.java:
##########
@@ -480,6 +482,14 @@ private void testKeyedMapStateUpgrade(
// make sure that reading and writing each key state works with
the new serializer
backend.setCurrentKey(1);
Iterator<Map.Entry<Integer, TestType>> iterable1 =
mapState.iterator();
+
+ List<Map.Entry<Integer, TestType>> actualList =
Review Comment:
1. Could you put them into a seprate method, like `sortedIterator` ?
2. a minor suggestion: Use TreeMap to avoid manual sort
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
