1996fanrui commented on PR #23217: URL: https://github.com/apache/flink/pull/23217#issuecomment-1695114942
> The thing I didn't get is that from one side there are downstream test dependencies (test-jar and I mean flink modules depending on this) which could depend on JUnit4. After that change the extension will be bundled by default... Before we intentionally excluded it in poms How does this PR solve this issue? Hi @snuyanzin , thanks for your quick feedback here. Is there any additional effects if the extension be bundled for junit4 tests? I think it's fine for junit4 class because some reasons: - I have tried some junit4 tests, the `org.apache.flink.util.TestLoggerExtension` doesn't take effect. - Some modules have junit4 and junit5 tests, these moudles add the extension in itself, and these junit4 tests are fine. Such as: `flink-runtime` module. (This case is similar to adding the extension for module that with junit4 tests.) If it doesn't have any additional effects, unifying the extension may be fine. In the end, all junit4 tests will be migrated to junit5. I don't know whether I missed something, please correct me if I'm wrong, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
