XComp commented on code in PR #23296:
URL: https://github.com/apache/flink/pull/23296#discussion_r1308279128
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/collect/CollectSinkOperatorCoordinator.java:
##########
@@ -152,9 +176,11 @@ private CoordinationResponse handleRequestImpl(
throw new NullPointerException("No sinkAddress available.");
}
- if (socketConnection == null) {
- socketConnection = SocketConnection.create(socketTimeout,
sinkAddress);
- LOG.info("Sink connection established");
+ synchronized (connectionLock) {
+ if (running && socketConnection == null) {
Review Comment:
Good point. This remark became obsolete because I removed the
synchronization again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
