[ 
https://issues.apache.org/jira/browse/FLINK-4391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15633159#comment-15633159
 ] 

ASF GitHub Bot commented on FLINK-4391:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2629#discussion_r86344377
  
    --- Diff: 
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/operators/async/AsyncCollectorBufferTest.java
 ---
    @@ -0,0 +1,293 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.api.operators.async;
    +
    +import org.apache.flink.streaming.api.datastream.AsyncDataStream;
    +import org.apache.flink.streaming.api.functions.async.AsyncFunction;
    +import org.apache.flink.streaming.api.operators.AbstractStreamOperator;
    +import org.apache.flink.streaming.api.operators.Output;
    +import org.apache.flink.streaming.api.operators.TimestampedCollector;
    +import org.apache.flink.streaming.api.watermark.Watermark;
    +import org.apache.flink.streaming.runtime.streamrecord.LatencyMarker;
    +import org.apache.flink.streaming.runtime.streamrecord.StreamElement;
    +import org.apache.flink.streaming.runtime.streamrecord.StreamRecord;
    +import org.junit.Assert;
    +import org.junit.Before;
    +import org.junit.Test;
    +import org.mockito.internal.util.reflection.Whitebox;
    +
    +import java.io.IOException;
    +import java.lang.reflect.Constructor;
    +import java.util.ArrayList;
    +import java.util.Arrays;
    +import java.util.Collection;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.concurrent.ExecutorService;
    +import java.util.concurrent.Executors;
    +
    +/**
    + * Tests for {@link AsyncCollectorBuffer}. These test that:
    + *
    + * <ul>
    + *     <li>Add a new item into the buffer</li>
    + *     <li>Ordered mode processing</li>
    + *     <li>Unordered mode processing</li>
    + *     <li>Error handling</li>
    + * </ul>
    + */
    +public class AsyncCollectorBufferTest {
    +   private AsyncFunction<Integer, Integer> function;
    +
    +   private AsyncWaitOperator<Integer, Integer> operator;
    +
    +   private AsyncCollectorBuffer<Integer, Integer> buffer;
    +
    +   private Output<StreamRecord<Integer>> output;
    +
    +   @Before
    +   public void setUp() throws Exception {
    +           function = new AsyncFunction<Integer, Integer>() {
    +                   @Override
    +                   public void asyncInvoke(Integer input, 
AsyncCollector<Integer, Integer> collector) throws Exception {
    +
    +                   }
    +           };
    +
    +           operator = new AsyncWaitOperator<>(function);
    +           Class<?>[] classes = 
AbstractStreamOperator.class.getDeclaredClasses();
    +           Class<?> latencyClass = null;
    +           for (Class<?> c : classes) {
    +                   if (c.getName().indexOf("LatencyGauge") != -1) {
    +                           latencyClass = c;
    +                   }
    +           }
    +
    +           Constructor<?> explicitConstructor = 
latencyClass.getDeclaredConstructors()[0];
    +           explicitConstructor.setAccessible(true);
    +           Whitebox.setInternalState(operator, "latencyGauge", 
explicitConstructor.newInstance(10));
    +
    +           output = new FakedOutput(new ArrayList<Long>());
    +           TimestampedCollector<Integer> collector =new 
TimestampedCollector(output);
    +           buffer =
    +                   new AsyncCollectorBuffer<>(3, 
AsyncDataStream.OutputMode.ORDERED, operator);
    +           buffer.setOutput(collector, output);
    +
    +           Whitebox.setInternalState(operator, "output", output);
    +   }
    +
    +   @Test
    +   public void testAdd() throws Exception {
    +           Thread.sleep(1000);
    --- End diff --
    
    Why the `sleep` here?


> Provide support for asynchronous operations over streams
> --------------------------------------------------------
>
>                 Key: FLINK-4391
>                 URL: https://issues.apache.org/jira/browse/FLINK-4391
>             Project: Flink
>          Issue Type: New Feature
>          Components: DataStream API
>            Reporter: Jamie Grier
>            Assignee: david.wang
>
> Many Flink users need to do asynchronous processing driven by data from a 
> DataStream.  The classic example would be joining against an external 
> database in order to enrich a stream with extra information.
> It would be nice to add general support for this type of operation in the 
> Flink API.  Ideally this could simply take the form of a new operator that 
> manages async operations, keeps so many of them in flight, and then emits 
> results to downstream operators as the async operations complete.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to