gaborgsomogyi opened a new pull request, #23329: URL: https://github.com/apache/flink/pull/23329
## What is the purpose of the change https://github.com/apache/flink/pull/23306 introduced a blocker issue because the underneath directories to detect Flink home are not always exist. In this PR I've added better way to find out Flink version and home. Namely the version comes from the root `pom.xml` file which is an existing pattern in the code base. ## Brief change log The version comes from the root `pom.xml` file which is an existing pattern in the code base. ## Verifying this change Manually. Test to cover the original feature: ``` # Change pyflink version to: 1.19.post0.dev0 # OR # Change Flink version to: 1.19-foo-SNAPSHOT cd flink mvn clean install -DskipTests conda env remove -n venv conda create -y -n venv python=3.10 conda activate venv pip3 install -r flink-python/dev/dev-requirements.txt cd flink-python python3 setup.py sdist bdist_wheel cd apache-flink-libraries python3 setup.py sdist ``` Test which covers the broken feature: ``` cd flink/flink-python dev/build-wheels.sh ``` ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
