swuferhong commented on PR #23330: URL: https://github.com/apache/flink/pull/23330#issuecomment-1698994681
Hi, @Jiabao-Sun, thanks for your contribution. IMO, there are too many tests in the table-planner module. Migrating all tests to junit5 at once has a significant impact to current pr and tests. Can we complete the migration in a smoother way? For example, adding StreamingTestBaseV2 (junit5) and BatchTestBaseV2 (junit5), and then new tests extended StreamingTestBaseV2 when modifying and exists tests gradually migrates. This may have a smaller impact on existing code and developers. cc @lincoln-lil and @wuchong . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
