[ 
https://issues.apache.org/jira/browse/FLINK-32997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760342#comment-17760342
 ] 

Yunhong Zheng commented on FLINK-32997:
---------------------------------------

Hi, [~jiabao.sun] , thanks for your contribution. IMO, there are too many tests 
in the table-planner module. Migrating all tests to junit5 at once has a 
significant impact to current pr and tests. Can we complete the migration in a 
smoother way? For example, adding StreamingTestBaseV2 (junit5) and 
BatchTestBaseV2 (junit5), and then new tests extended StreamingTestBaseV2 when 
modifying and exists tests gradually migrates. This may have a smaller impact 
on existing code and developers.  cc [~lincoln.86xy]  [~jark] 

> [JUnit5 Migration] Module: flink-table-planner (StreamingTestBase)
> ------------------------------------------------------------------
>
>                 Key: FLINK-32997
>                 URL: https://issues.apache.org/jira/browse/FLINK-32997
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Tests
>    Affects Versions: 1.18.0
>            Reporter: Jiabao Sun
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.19.0
>
>
> JUnit5 Migration Module: flink-table-planner (StreamingTestBase)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to