lincoln-lil commented on code in PR #23316:
URL: https://github.com/apache/flink/pull/23316#discussion_r1310026882
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecLookupJoin.java:
##########
@@ -175,9 +177,14 @@ public abstract class CommonExecLookupJoin extends
ExecNodeBase<RowData> {
@JsonProperty(FIELD_NAME_FILTER_ON_TEMPORAL_TABLE)
private final @Nullable RexNode filterOnTemporalTable;
- /** join condition except equi-conditions extracted as lookup keys. */
- @JsonProperty(FIELD_NAME_JOIN_CONDITION)
- private final @Nullable RexNode joinCondition;
+ /** pre-filter condition on left input except lookup keys. */
+ @JsonProperty(FIELD_NAME_PRE_FILTER_CONDITION)
+ @JsonInclude(JsonInclude.Include.NON_NULL)
+ private final @Nullable RexNode preFilterCondition;
+
+ /** remaining join condition except pre-filter & equi-conditions except
lookup keys. */
+ @JsonProperty(FIELD_NAME_REMAINING_JOIN_CONDITION)
+ private final @Nullable RexNode remainingJoinCondition;
Review Comment:
The main reason for not adding 'NON_NULL' json annotation is to support
older versions of serialized json plan for compatibility reasons.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
