XComp commented on code in PR #23295:
URL: https://github.com/apache/flink/pull/23295#discussion_r1310315320
##########
flink-runtime/src/test/java/org/apache/flink/runtime/checkpoint/ZooKeeperCompletedCheckpointStoreITCase.java:
##########
@@ -317,15 +314,15 @@ public void testConcurrentCheckpointOperations() throws
Exception {
List<CompletedCheckpoint> allCheckpoints =
zkCheckpointStore1.getAllCheckpoints();
// check that we have removed the first checkpoint from
zkCompletedStore1
- assertEquals(Collections.singletonList(completedCheckpoint2),
allCheckpoints);
+
assertThat(allCheckpoints).isEqualTo(Collections.singletonList(completedCheckpoint2));
Review Comment:
```suggestion
assertThat(allCheckpoints).containsExactly(completedCheckpoint2);
```
nit
##########
flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java:
##########
@@ -237,22 +217,21 @@ public void flatMap(Long value, Collector<Long> out)
}
});
- result.output(new DiscardingOutputFormat<Long>());
+ result.output(new DiscardingOutputFormat<>());
env.execute();
}
- @Test
- public void testDispatcherProcessFailure() throws Exception {
- final Time timeout = Time.seconds(30L);
- final File zookeeperStoragePath = temporaryFolder.newFolder();
+ @TestTemplate
+ void testDispatcherProcessFailure() throws Exception {
Review Comment:
```suggestion
void testDispatcherProcessFailure(@TempDir Path tempDir) throws
Exception {
```
nit: you can also inject the tempDir as a parameter (instead of creating the
field in the test class) since it's only used in this one test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
