KarmaGYZ commented on code in PR #23201:
URL: https://github.com/apache/flink/pull/23201#discussion_r1311522921
##########
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java:
##########
@@ -128,20 +152,13 @@ public ResourceAllocationResult tryFulfillRequirements(
// tryFulFillRedundantResources will not update pendingResources even
after new
// PendingTaskManagers are created.
// This is because the pendingResources are no longer needed
afterwards.
- tryFulFillRedundantResources(
- totalResourceProfile.multiply(redundantTaskManagerNum),
- registeredResources,
- pendingResources,
- resultBuilder);
-
+ tryFulFillRequiredResources(registeredResources, pendingResources,
resultBuilder);
Review Comment:
The `registeredResources` and `pendingResources` could be modified and thus
might be incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
