ljw-hit commented on code in PR #23162:
URL: https://github.com/apache/flink/pull/23162#discussion_r1312639211
##########
flink-formats/flink-protobuf/src/main/java/org/apache/flink/formats/protobuf/deserialize/PbCodegenRowDeserializer.java:
##########
@@ -100,6 +102,85 @@ public String codegen(String resultVar, String
pbObjectCode, int indent)
return appender.code();
}
+ @Override
+ public String codegenSplit(
Review Comment:
Not all codegen should be split at the beginning of the design. Only when
the code exceeds the threshold will it be split, which can reduce the scope of
the affected codegen. I think that providing two interfaces can be flexibly
selected according to the situation, and sometimes it is not the best after
splitting, for example, if there are some internal connection methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
