Myasuka commented on code in PR #14611: URL: https://github.com/apache/flink/pull/14611#discussion_r1312966645
########## flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedStateBackend.java: ########## @@ -30,6 +30,11 @@ /** * A keyed state backend provides methods for managing keyed state. * + * <h2>Not Thread-Safe</h2> + * + * State access in keyed state backend dose not require thread safety as each task is executed by + * one thread. Current implementations (Heap/RocksDB keyed state backend) are not thread-safe. + * Review Comment: I think this is a good suggestion. Apart from adding this tag on state backends, I prefer to add to Heap/RocksDB state which offer ability for read and write. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
