hlteoh37 commented on code in PR #92: URL: https://github.com/apache/flink-connector-aws/pull/92#discussion_r1314643107
########## flink-connector-aws/flink-connector-aws-kinesis-streams/src/main/java/org/apache/flink/connector/kinesis/source/enumerator/KinesisStreamsSourceEnumerator.java: ########## @@ -30,10 +30,6 @@ import org.apache.flink.connector.kinesis.source.split.KinesisShardSplit; import org.apache.flink.connector.kinesis.source.split.StartingPosition; -import org.apache.flink.shaded.guava30.com.google.common.collect.ImmutableList; Review Comment: All the changes that changed `ImmutableXXX` to `Streams` were in tests. We do not need to use a `ImmutableXXX`. Regarding wrapping using `Collections` + performance - that is not important for the cases we have changed: 1. We changed the `SourceEnumerator` which regularly enumerates the splits from the Kinesis Data Stream. Not that important for performance of the data job! (Also runs on job manager) 2. We also changed the tests - this level of performance checking is not required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
