dawidwys commented on code in PR #23365:
URL: https://github.com/apache/flink/pull/23365#discussion_r1316930548


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/config/TableConfigOptions.java:
##########
@@ -313,4 +325,32 @@ public InlineElement getDescription() {
             return description;
         }
     }
+
+    /** Strategy to expand columns in {@code SELECT *} queries. */
+    @PublicEvolving
+    public enum ColumnExpansionStrategy implements DescribedEnum {
+        EXCLUDE_ALIASED_VIRTUAL_METADATA_COLUMNS(
+                text(
+                        "Excludes virtual metadata columns that reference a 
metadata key via an alias. "
+                                + "For example, a column declared as 'c 
METADATA VIRTUAL FROM k' "
+                                + "is not selected by default if the strategy 
is applied.")),
+
+        EXCLUDE_DEFAULT_VIRTUAL_METADATA_COLUMNS(
+                text(
+                        "Excludes virtual metadata columns that directly 
reference a metadata key. "
+                                + "For example, a column declared as 'k 
METADATA VIRTUAL' "
+                                + "is not selected by default if the strategy 
is applied."));

Review Comment:
   Why would we want to exclude one and not the other? I'm wondering if we need 
the two values. I'm fine the way it is, just wanted to understand what's the 
idea here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to