ldadima commented on code in PR #23355:
URL: https://github.com/apache/flink/pull/23355#discussion_r1318061178


##########
flink-runtime/src/test/java/org/apache/flink/runtime/state/StateBackendTestBase.java:
##########
@@ -500,6 +493,7 @@ public void testGetKeysAndNamespaces() throws Exception {
                                     keysByNamespace.computeIfAbsent(entry.f1, 
k -> new HashSet<>());
                             assertTrue("Duplicate key for namespace", 
keys.add(entry.f0));
                         });
+                assertThat(keysByNamespace.size(), is(namespaces.length));

Review Comment:
   On Flink 
[website](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/)
 we can find this
   "And instead use:"
   
   ```
   assertThat(list)
       .hasSize(10)
       .allMatch(item -> item.length() < 10);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to