huwh commented on code in PR #23368:
URL: https://github.com/apache/flink/pull/23368#discussion_r1320962443
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/collect/CollectResultFetcher.java:
##########
@@ -67,20 +66,23 @@ public class CollectResultFetcher<T> {
public CollectResultFetcher(
AbstractCollectResultBuffer<T> buffer,
CompletableFuture<OperatorID> operatorIdFuture,
- String accumulatorName) {
- this(buffer, operatorIdFuture, accumulatorName, DEFAULT_RETRY_MILLIS);
+ String accumulatorName,
+ long resultFetchTimeout) {
+ this(buffer, operatorIdFuture, accumulatorName, DEFAULT_RETRY_MILLIS,
resultFetchTimeout);
Review Comment:
Should we move the DEFAULT_RETRY_MILLIS to the CollectResultIterator?
In this way, we can only keep one constructor for CollectResultFetcher. In
the constructor of CollectResultIterator, we can use this(xxx) to avoid
different logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
