elkhand commented on code in PR #23383:
URL: https://github.com/apache/flink/pull/23383#discussion_r1321874986
##########
flink-clients/src/main/java/org/apache/flink/client/program/rest/UrlPrefixDecorator.java:
##########
@@ -41,7 +40,7 @@
*/
public class UrlPrefixDecorator<
R extends RequestBody, P extends ResponseBody, M extends
MessageParameters>
- implements SqlGatewayMessageHeaders<R, P, M> {
Review Comment:
It is used in other places which is not related to this PR. But the reason
`UrlPrefixDecorator` implemented `SqlGatewayMessageHeaders` to fetch
`SqlGatewayRestAPIVersion::isStableVersion`, as `UrlPrefixDecorator` was
initially meant to be used only with FlinkSQLGateway.
Now I intend to move `UrlPrefixDecorator` into `flink-clients` module, so
that `UrlPrefixDecorator` can be used by RestClusterClient also for PyFlink
remote execution. `flink-sql-gateway` has dependency on `flink-clients` module,
thus will be able to extend `UrlPrefixDecorator` class and use it also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
