gyfora commented on code in PR #672:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/672#discussion_r1324633942
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/JobAutoScalerImpl.java:
##########
@@ -74,6 +76,36 @@ public JobAutoScalerImpl(
this.infoManager = new AutoscalerInfoManager();
}
+ @Override
+ public void scale(FlinkResourceContext<?> ctx) {
+ var conf = ctx.getObserveConfig();
+ var resource = ctx.getResource();
+ var resourceId = ResourceID.fromResource(resource);
+ var autoscalerMetrics = getOrInitAutoscalerFlinkMetrics(ctx,
resourceId);
+
Review Comment:
I think the `finally` block is fairly clean and makes it obvious that
overrides are applied always, exactly once at the very end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
