TanYuxin-tyx commented on code in PR #22804: URL: https://github.com/apache/flink/pull/22804#discussion_r1247344923
########## flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskCacheManager.java: ########## @@ -0,0 +1,174 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.runtime.io.network.partition.hybrid.tiered.tier.disk; + +import org.apache.flink.api.java.tuple.Tuple2; +import org.apache.flink.runtime.io.network.buffer.Buffer; +import org.apache.flink.runtime.io.network.partition.hybrid.tiered.common.TieredStoragePartitionId; +import org.apache.flink.runtime.io.network.partition.hybrid.tiered.file.PartitionFileWriter; +import org.apache.flink.runtime.io.network.partition.hybrid.tiered.storage.TieredStorageMemoryManager; +import org.apache.flink.util.concurrent.FutureUtils; + +import java.nio.ByteBuffer; +import java.util.ArrayList; +import java.util.Arrays; +import java.util.Collections; +import java.util.List; +import java.util.concurrent.CompletableFuture; + +/** + * The {@link DiskCacheManager} is responsible for managing cached buffers before flushing to files. + */ +class DiskCacheManager { + + private final TieredStoragePartitionId partitionId; + + private final int numSubpartitions; + + private final PartitionFileWriter partitionFileWriter; + + private final SubpartitionDiskCacheManager[] subpartitionCacheManagers; + + /** Whether the current flush process has completed. */ + private CompletableFuture<Void> hasFlushCompleted; + + DiskCacheManager( + TieredStoragePartitionId partitionId, + int numSubpartitions, + TieredStorageMemoryManager storageMemoryManager, + PartitionFileWriter partitionFileWriter) { + this.partitionId = partitionId; + this.numSubpartitions = numSubpartitions; + this.partitionFileWriter = partitionFileWriter; + this.subpartitionCacheManagers = new SubpartitionDiskCacheManager[numSubpartitions]; + this.hasFlushCompleted = FutureUtils.completedVoidFuture(); + + for (int subpartitionId = 0; subpartitionId < numSubpartitions; ++subpartitionId) { + subpartitionCacheManagers[subpartitionId] = new SubpartitionDiskCacheManager(); + } + storageMemoryManager.listenBufferReclaimRequest(this::notifyFlushCachedBuffers); + } + + // ------------------------------------------------------------------------ + // Called by DiskTierProducerAgent + // ------------------------------------------------------------------------ + + /** + * Append buffer to {@link DiskCacheManager}. + * + * @param buffer to be managed by this class. + * @param subpartitionId the subpartition of this record. + */ + void append(Buffer buffer, int subpartitionId) { + subpartitionCacheManagers[subpartitionId].append(buffer); + } + + /** + * Append the end-of-segment event to {@link DiskCacheManager}, which indicates the segment has + * finished. + * + * @param record the end-of-segment event + * @param subpartitionId target subpartition of this record. + * @param dataType the type of this record. In other words, is it data or event. + */ + void appendEndOfSegmentEvent(ByteBuffer record, int subpartitionId, Buffer.DataType dataType) { + subpartitionCacheManagers[subpartitionId].appendEndOfSegmentEvent(record, dataType); + + // When finishing a segment, the buffers should be flushed because the next segment may be + // written to another tier. If the buffers in this tier are not flushed here, then the next + // segment in another tier may be stuck by lacking buffers. This flush has a low trigger + // frequency, so its impact on performance is relatively small. + forceFlushCachedBuffers(); + } + + /** + * Return the current buffer index. + * + * @param subpartitionId the target subpartition id + * @return the finished buffer index + */ + int getBufferIndex(int subpartitionId) { + return subpartitionCacheManagers[subpartitionId].getBufferIndex(); + } + + /** Close this {@link DiskCacheManager}, it means no data can append to memory. */ + void close() { + forceFlushCachedBuffers(); + } + + /** + * Release this {@link DiskCacheManager}, it means all memory taken by this class will recycle. + */ + void release() { + Arrays.stream(subpartitionCacheManagers).forEach(SubpartitionDiskCacheManager::release); + partitionFileWriter.release(); + } + + // ------------------------------------------------------------------------ + // Internal Methods + // ------------------------------------------------------------------------ + + private void notifyFlushCachedBuffers() { + flushBuffers(false); + } + + private void forceFlushCachedBuffers() { + flushBuffers(true); + } + + /** + * Note that the request of flushing buffers may come from the disk check thread or the task + * thread, so the method itself should ensure the thread safety. + */ + private synchronized void flushBuffers(boolean needForceFlush) { Review Comment: fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
