xintongsong commented on code in PR #23369:
URL: https://github.com/apache/flink/pull/23369#discussion_r1329903027
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/tier/disk/DiskCacheManager.java:
##########
@@ -81,6 +91,7 @@ void startSegment(int subpartitionId, int segmentIndex) {
*/
void append(Buffer buffer, int subpartitionId) {
subpartitionCacheManagers[subpartitionId].append(buffer);
+ numCachedBytesCounter += buffer.readableBytes();
Review Comment:
Shouldn't we also check whether the max is reached here? Otherwise, we may
exceed the max a lot when one of the segments end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
