Tartarus0zm commented on code in PR #23389: URL: https://github.com/apache/flink/pull/23389#discussion_r1329949812
########## docs/content/docs/dev/table/sql/create.md: ########## @@ -616,6 +616,7 @@ INSERT INTO my_rtas_table SELECT id, name, age FROM source_table WHERE mod(id, 1 * Does not support specifying primary key constraints yet. **Note:** By default, RTAS is non-atomic which means the table won't be dropped or restored to its origin automatically if occur errors while inserting data into the table. +**Note:** In the InMemoryCatalog scenario, the drop table only removes the metadata and does not clean up the underlying data, when reusing RTAS, it is recommended to make sure that the underlying data has been cleaned up first, otherwise it may look like the data is duplicated. Review Comment: thanks for your review! The root cause is not clear enough if it's executed via sql-client, so we want to be able to tell the user that this DynamicTableSink doesn't support atomicity and needs to be turned off. See [FLINK-32787](https://issues.apache.org/jira/browse/FLINK-32787) for details. ########## docs/content/docs/dev/table/sql/create.md: ########## @@ -616,6 +616,7 @@ INSERT INTO my_rtas_table SELECT id, name, age FROM source_table WHERE mod(id, 1 * Does not support specifying primary key constraints yet. **Note:** By default, RTAS is non-atomic which means the table won't be dropped or restored to its origin automatically if occur errors while inserting data into the table. +**Note:** In the InMemoryCatalog scenario, the drop table only removes the metadata and does not clean up the underlying data, when reusing RTAS, it is recommended to make sure that the underlying data has been cleaned up first, otherwise it may look like the data is duplicated. Review Comment: thanks for your review! The root cause is not clear enough if it's executed via sql-client, so we want to be able to tell the user that this DynamicTableSink doesn't support atomicity and needs to be turned off. See [FLINK-32787](https://issues.apache.org/jira/browse/FLINK-32787) for details. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
