luoyuxia commented on code in PR #23353:
URL: https://github.com/apache/flink/pull/23353#discussion_r1330032479
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/utils/JsonPlanTestBase.java:
##########
@@ -53,17 +58,30 @@
import static org.assertj.core.api.Assertions.assertThat;
/** The base class for json plan testing. */
-public abstract class JsonPlanTestBase extends AbstractTestBase {
+public abstract class JsonPlanTestBase {
+
+ private static final int DEFAULT_TASK_MANAGERS = 1;
+ private static final int DEFAULT_PARALLELISM = 4;
+
+ @RegisterExtension
+ private static final MiniClusterExtension MINI_CLUSTER_EXTENSION =
+ new MiniClusterExtension(
+ new MiniClusterResourceConfiguration.Builder()
+ .setNumberTaskManagers(DEFAULT_TASK_MANAGERS)
+ .setNumberSlotsPerTaskManager(DEFAULT_PARALLELISM)
Review Comment:
```suggestion
.setNumberSlotsPerTaskManager(1)
```
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/utils/JsonPlanTestBase.java:
##########
@@ -53,17 +58,30 @@
import static org.assertj.core.api.Assertions.assertThat;
/** The base class for json plan testing. */
-public abstract class JsonPlanTestBase extends AbstractTestBase {
+public abstract class JsonPlanTestBase {
+
+ private static final int DEFAULT_TASK_MANAGERS = 1;
+ private static final int DEFAULT_PARALLELISM = 4;
+
+ @RegisterExtension
+ private static final MiniClusterExtension MINI_CLUSTER_EXTENSION =
+ new MiniClusterExtension(
+ new MiniClusterResourceConfiguration.Builder()
+ .setNumberTaskManagers(DEFAULT_TASK_MANAGERS)
Review Comment:
Nit: For simiplicity,
```suggestion
.setNumberTaskManagers(4)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
