wangzzu commented on code in PR #23243:
URL: https://github.com/apache/flink/pull/23243#discussion_r1330326631
##########
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/dump/MetricQueryServiceTest.java:
##########
@@ -106,14 +104,14 @@ public void testCreateDump() throws Exception {
MetricDumpSerialization.MetricSerializationResult emptyDump =
queryService.queryMetrics(TIMEOUT).get();
- assertEquals(0, emptyDump.serializedCounters.length);
- assertEquals(0, emptyDump.serializedGauges.length);
- assertEquals(0, emptyDump.serializedHistograms.length);
- assertEquals(0, emptyDump.serializedMeters.length);
+ assertThat(emptyDump.serializedCounters.length).isZero();
Review Comment:
fixed
##########
flink-runtime/src/test/java/org/apache/flink/runtime/metrics/util/MetricUtilsTest.java:
##########
@@ -73,7 +70,7 @@ public void cleanupReferencedObjects() {
* RpcSystem)} respects the given {@link
MetricOptions#QUERY_SERVICE_THREAD_PRIORITY}.
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
