JunRuiLee commented on PR #23447: URL: https://github.com/apache/flink/pull/23447#issuecomment-1731028477
@X-czh Hi Zhanghao, thanks for your effort. After a quick review of your PR, if I understand correctly, your changes will remove all metrics from the operators in the terminal state. I think this change is not entirely reliable because some non-transient metrics like numRecordsIn and numRecordsOut should not be removed just although the task state becomes finished. I would prefer to remove only those metrics that may cause confused when the tasks in the terminal state, and the decision on which metrics are unnecessary for terminal state tasks should be determined through community discussion. However, to keep it simple for this PR, I could also accept the removal of only the backpressure-related metrics mentioned in this issue. Both approaches are acceptable to me. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
