davidradl commented on code in PR #23465:
URL: https://github.com/apache/flink/pull/23465#discussion_r1337230247
##########
flink-runtime/src/main/java/org/apache/flink/runtime/rest/messages/JobExceptionsInfo.java:
##########
@@ -190,21 +193,21 @@ public boolean equals(Object o) {
return timestamp == that.timestamp
&& Objects.equals(exception, that.exception)
&& Objects.equals(task, that.task)
- && Objects.equals(location, that.location)
+ && Objects.equals(endpoint, that.endpoint)
Review Comment:
if an old object with location = aaaa:1234 and endpoint unset . If we
compare this with a new object with endpoint = aaaa:1234 but location not set.
This test would say they are unequal, but the objects have the same hash (as
the toString of location and endpoint are the same I think).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
