[
https://issues.apache.org/jira/browse/FLINK-33159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17769280#comment-17769280
]
david radley edited comment on FLINK-33159 at 9/26/23 7:14 PM:
---------------------------------------------------------------
Hi [~martijnvisser] , I see this change as cleaning up the pom file to use the
variables - it should not change anything functionally. Do you think this
introduces some change in behaviour somehow?
The pr is here - [https://github.com/apache/flink/pull/23469] hopefully this
does not concern you. Sorry if my wording of this Jira was misleading.
was (Author: JIRAUSER300523):
Hi [~martijnvisser] , I see this change as cleaning up the pom file to use the
variables - it should not change anything functionally. Do you think this
introduces some change in behaviour somehow?
> Use the variables for java and Maven version checks in the pom file
> --------------------------------------------------------------------
>
> Key: FLINK-33159
> URL: https://issues.apache.org/jira/browse/FLINK-33159
> Project: Flink
> Issue Type: Improvement
> Components: Build System
> Reporter: david radley
> Priority: Minor
> Labels: pull-request-available
>
> Use the variables for java and Maven version checks in the pom file.
> In the pom file I notice line
> _<requireJavaVersion>_
> _<version>1.8.0</version>_
> _</requireJavaVersion>_
> This should use the variable like this:
> \{_}<version>{_}${target.java.version}{_}</version>{_}
> I also see 2 instanced of _<target.java.version>1.8</target.java.version>_
> The second instance should refer to the variable
> also the Maven versions should use variables.
>
> I will provide a pr for this.
>
>
>
>
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
