Gerrrr commented on code in PR #52:
URL:
https://github.com/apache/flink-connector-kafka/pull/52#discussion_r1338053462
##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/reader/KafkaPartitionSplitReader.java:
##########
@@ -205,11 +201,9 @@ public void
handleSplitsChanges(SplitsChange<KafkaPartitionSplit> splitsChange)
// Seek on the newly assigned partitions to their stating offsets.
seekToStartingOffsets(
- partitionsStartingFromEarliest,
- partitionsStartingFromLatest,
- partitionsStartingFromSpecifiedOffsets);
+ partitionsStartingFromEarliest,
partitionsStartingFromSpecifiedOffsets);
// Setup the stopping offsets.
- acquireAndSetStoppingOffsets(partitionsStoppingAtLatest,
partitionsStoppingAtCommitted);
+ acquireAndSetStoppingOffsets(partitionsStoppingAtCommitted);
Review Comment:
nit: with this method only acquiring committed offsets, we should change its
name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
