dawidwys commented on code in PR #23223:
URL: https://github.com/apache/flink/pull/23223#discussion_r1340991937
##########
docs/layouts/shortcodes/generated/table_config_configuration.html:
##########
@@ -62,6 +62,12 @@
<td>String</td>
<td>The local time zone defines current session time zone id. It
is used when converting to/from <code>TIMESTAMP WITH LOCAL TIME
ZONE</code>. Internally, timestamps with local time zone are always
represented in the UTC time zone. However, when converting to data types that
don't include a time zone (e.g. TIMESTAMP, TIME, or simply STRING), the session
time zone is used during conversion. The input of option is either a full name
such as "America/Los_Angeles", or a custom timezone id such as "GMT-08:00".</td>
</tr>
+ <tr>
+ <td><h5>table.optimizer.query-hints.enabled</h5><br> <span
class="label label-primary">Batch</span> <span class="label
label-primary">Streaming</span></td>
Review Comment:
cc @wuchong Hey Jark, I am reaching out to you since you suggested the
`table.optimizer.ignore-query-hints`. I think Bonnie has a good point here that
`table.optimizer.query-hints.enabled` would be more consistent with other
configs:
```
table.dynamic-table-options.enabled
table.optimizer.distinct-agg.split.enabled
table.optimizer.dynamic-filtering.enabled
...
```
Moreover, I think `ignore-query-hints` would be a bit misleading. From my
point of view it would suggest query hints are simply ignored, but from what
I've gathered the agreed behaviour is to throw an exception which is not
necessarily ignoring hints.
Would you be ok with naming the config `table.optimizer.query-hints.enabled`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
