[
https://issues.apache.org/jira/browse/FLINK-4596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15636294#comment-15636294
]
ASF GitHub Bot commented on FLINK-4596:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/2592#discussion_r86542348
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala
---
@@ -1114,7 +1114,8 @@ class JobManager(
Option(jobGraph.getSerializedExecutionConfig()
--- End diff --
True, you're right because it would prevent the
`StreamingJobGraphGenerator` from setting the `FixedDelayRestartStrategy` in
case that no other restarting strategy has been set.
> RESTART_STRATEGY is not really pluggable
> ----------------------------------------
>
> Key: FLINK-4596
> URL: https://issues.apache.org/jira/browse/FLINK-4596
> Project: Flink
> Issue Type: Wish
> Components: Distributed Coordination
> Affects Versions: 1.2.0
> Reporter: Nagarjun Guraja
>
> Standalone cluster config accepts an implementation(class) as part of the
> yaml config file but that does not work either as cluster level restart
> strategy or streaming job level restart strategy
> CLUSTER LEVEL CAUSE: createRestartStrategyFactory converts configured value
> of strategyname to lowercase and searches for class name using lowercased
> string.
> JOB LEVEL CAUSE: Checkpointed streams have specific code to add
> fixeddelayrestartconfiguration if no RestartConfiguration is specified in
> the job env. Also, jobs cannot provide their own custom restart strategy
> implementation and are constrained to pick up one of the three restart
> strategies provided by flink.
> FIX: Do not lower case the strategy config value, support a new
> restartconfiguration to fallback to cluster level restart strategy and
> support jobs to provide custom implementation of the strategy class itself.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
