srpraneeth opened a new pull request, #682:
URL: https://github.com/apache/flink-kubernetes-operator/pull/682
## What is the purpose of the change
*Currently the AutoScaler configurations are not validated, hence they fail
at runtime. This change intends to introduce a validator plugin for validating
AutoScaler configuration*
## Brief change log
- *AutoScaler Validator implemented using FlinkResourceValidator plugin*
- *Unit tests added for the same, please find below details of all the
rules being validated*
- *Added the META-INF/services file for the validator to pick the right
autoscaler plugin while available in classpath*
## Verifying this change
This change added tests and can be verified as follows:
- *Added Unit tests to cover all the rules validated on the autoscaler
configuration.*
- *Extended e2e-tests to make sure the AutoScaler validator plugin is
picked and validated on the tests*
- *Manually verified the change by running a test on the operator with a
flinkdeployment with the CR voilating the validation rules.*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changes to the `CustomResourceDescriptors`:
no
- Core observer or reconciler logic that is regularly executed: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
## Properties and Rules validated by the AutoScaler Configuration
|| Rule | Affecting Property | MinValue | MaxValue |
|-| ----------- | ----------- | ----------- | ----------- |
|1| validateMaxScaleDownFactor |
kubernetes.operator.job.autoscaler.scale-down.max-factor | 0.0d | 1.0d |
|2| validateMaxScaleUpFactor |
kubernetes.operator.job.autoscaler.scale-up.max-factor | 1.0d | 100000.0d |
|3| validateTargetUtilization |
kubernetes.operator.job.autoscaler.target.utilization | 0.0d | 1.0d |
|4| validateTargetUtilizationBoundary |
kubernetes.operator.job.autoscaler.target.utilization.boundary | 0.0d | 1.0d |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
