[
https://issues.apache.org/jira/browse/FLINK-33189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772024#comment-17772024
]
Vlado Vojdanovski edited comment on FLINK-33189 at 10/4/23 11:51 PM:
---------------------------------------------------------------------
For posterity, I was able to locate
https://issues.apache.org/jira/browse/FLINK-13856 and
https://issues.apache.org/jira/browse/FLINK-17860 that seemed somewhat similar.
However, these are both fairly old and I think some guidance on how a pluggable
File System should implement #delete is independently warranted.
was (Author: JIRAUSER302467):
For posterity, I was able to locate
https://issues.apache.org/jira/browse/FLINK-13856 that seemed similar as well
as https://issues.apache.org/jira/browse/FLINK-17860.
However, these are both fairly old and I think some guidance on how a pluggable
File System should implement #delete is independently warranted.
> FsCompletedCheckpointStorageLocation#disposeStorageLocation non-recursively
> deletes a directory
> -----------------------------------------------------------------------------------------------
>
> Key: FLINK-33189
> URL: https://issues.apache.org/jira/browse/FLINK-33189
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
> Reporter: Vlado Vojdanovski
> Priority: Major
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> FsCompletedCheckpointStorageLocation attempts to non-recursively delete a
> directory
> [https://github.com/apache/flink/blob/master/flink-runtime/src/main/java/org/apache/flink/runtime/state/filesystem/FsCompletedCheckpointStorageLocation.java#L74]
> However, per the documentation of Flink's FileSystem Interface, such attempts
> are supposed to fail.
> {code:java}
> * @param recursive if path is a directory and set to <code>true</code>,
> the directory is
> * deleted else throws an exception. In case of a file the recursive
> can be set to either
> * <code>true</code> or <code>false</code>{code}
> [https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/core/fs/FileSystem.java#L689]
> I am sure there is a non-negligible chance I am missing some flink internals
> here considering the class has not been touched since 2018 but my read is the
> above is either a bug, or it would be nice to update the FileSystem#delete
> docs.
> Thanks for taking a look :) !
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
