[
https://issues.apache.org/jira/browse/FLINK-33000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17772073#comment-17772073
]
Matthias Pohl edited comment on FLINK-33000 at 10/5/23 4:43 AM:
----------------------------------------------------------------
Summary of merged changes:
* master
** 8e68b40d5cf9146a5bccadc67d9636f987003c0f
** 73717520cc63df8bd08fd008ac004659b210cfd1
** de6c66ea805760f1550ae1fa348630edd9f17256
* 1.18
** 70ee020dc01224ee6e7acd63b60c43c2f5d8683f
** 4f11dfb2a70782ae1ae652126066e55a2fe7c945
** 5fbf5d5aa192682ed14f22203f3114fe07b1f60f
* 1.17
** 69142050e0f844421ccbe0e5173260eb12f26983
** 906216a4b541ae6ab413d8499c16f98aac84a592
** 2ad7d97c758622bd095303c8bc5b793f20c7612e
* 1.16
** 7f63abcbb14ec95ac4ea903bbe8519e0973a9bcf
** d9f8c419b89c2011320ef941fafd15526b5715aa
was (Author: mapohl):
Summary of merged changes:
master
* 8e68b40d5cf9146a5bccadc67d9636f987003c0f
* 73717520cc63df8bd08fd008ac004659b210cfd1
* de6c66ea805760f1550ae1fa348630edd9f17256
1.18
* 70ee020dc01224ee6e7acd63b60c43c2f5d8683f
* 4f11dfb2a70782ae1ae652126066e55a2fe7c945
* 5fbf5d5aa192682ed14f22203f3114fe07b1f60f
1.17
* 69142050e0f844421ccbe0e5173260eb12f26983
* 906216a4b541ae6ab413d8499c16f98aac84a592
* 2ad7d97c758622bd095303c8bc5b793f20c7612e
1.16
* 7f63abcbb14ec95ac4ea903bbe8519e0973a9bcf
* d9f8c419b89c2011320ef941fafd15526b5715aa
> SqlGatewayServiceITCase should utilize TestExecutorExtension instead of using
> a ThreadFactory
> ---------------------------------------------------------------------------------------------
>
> Key: FLINK-33000
> URL: https://issues.apache.org/jira/browse/FLINK-33000
> Project: Flink
> Issue Type: Bug
> Components: Table SQL / Gateway, Tests
> Affects Versions: 1.16.2, 1.18.0, 1.17.1, 1.19.0
> Reporter: Matthias Pohl
> Assignee: Jiabao Sun
> Priority: Major
> Labels: pull-request-available, starter
> Fix For: 1.16.3, 1.17.2, 1.19.0, 1.18.1
>
>
> {{SqlGatewayServiceITCase}} uses a {{ExecutorThreadFactory}} for its
> asynchronous operations. Instead, one should use {{TestExecutorExtension}} to
> ensure proper cleanup of threads.
> We might also want to remove the {{AbstractTestBase}} parent class because
> that uses JUnit4 whereas {{SqlGatewayServiceITCase}} is already based on
> JUnit5
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
