gyfora commented on code in PR #683:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/683#discussion_r1348864871
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingExecutor.java:
##########
@@ -94,14 +94,15 @@ public boolean scaleResource(
var scalingEnabled = conf.get(SCALING_ENABLED);
var scalingReport = scalingReport(scalingSummaries, scalingEnabled);
- eventRecorder.triggerEvent(
+ eventRecorder.triggerEventByInterval(
Review Comment:
We should only control the events by interval if `scalingEnabled == false`
(in advisor mode). Regular scaling should always trigger the event
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/config/AutoScalerOptions.java:
##########
@@ -168,4 +168,10 @@ private static ConfigOptions.OptionBuilder
autoScalerConfig(String key) {
.defaultValues()
.withDescription(
"A (semicolon-separated) list of vertex ids in
hexstring for which to disable scaling. Caution: For non-sink vertices this
will still scale their downstream operators until
https://issues.apache.org/jira/browse/FLINK-31215 is implemented.");
+
+ public static final ConfigOption<Long> SCALING_REPORT_INTERVAL =
+ autoScalerConfig("scaling.report.interval")
+ .longType()
Review Comment:
This should be a `Duration` type config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
