1996fanrui commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1349637114
##########
flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java:
##########
@@ -488,6 +488,23 @@ public enum SchedulerType {
code(SchedulerExecutionMode.REACTIVE.name()))
.build());
+ @Documentation.Section(Documentation.Sections.EXPERT_SCHEDULING)
+ public static final ConfigOption<Duration> SCHEDULER_SCALING_INTERVAL_MIN =
+ key("jobmanager.adaptive-scheduler.scaling-interval.min")
+ .durationType()
+ .defaultValue(Duration.ofSeconds(30))
+ // rescaling and let the user increase the value for high
workloads
+ .withDescription(
+ "Determines the minimum time (in seconds) between
scaling operations in reactive mode.");
Review Comment:
>> Is the in reactive mode exact? As I understand, this option is related to
adaptive scheduler even if the reactive mode is disable.
>
> 2. yes but new resources addition call that triggers the rescale (and the
cooldown period) only happens in reactive mode.
The rescale can happen when adaptive scheduler is enabled with reactive
mode[1]. And starting from `flink-1.18`, the rescale can happen when adaptive
scheduler is enabled with the rest api of FLIP-291 [1], right?
[1]
https://nightlies.apache.org/flink/flink-docs-release-1.18/docs/deployment/elastic_scaling/#reactive-mode
[2]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-291%3A+Externalized+Declarative+Resource+Management
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
