chucheng92 commented on PR #38:
URL: 
https://github.com/apache/flink-connector-kafka/pull/38#issuecomment-1757321797

   > @chucheng92 Looking at the dependency tree, there's still 
commons-collections coming in via Flink itself. If we want to remove the 
dependency, we should also make sure that it's not included from there
   
   Yes. I have updated the PR. 
   
   commons-collections in kafka connector is inherited from flink (so we will 
see it in kafka). This is a circular dependency and we should break it.
   
   What I am thinking about now is to change the kafka connector to 
commons-collections4. When the kafka connector is released, upgrade the 
kafka-connector that Python depends on to this version on the flink side. In 
this way, it is decoupled, and the flink side can also be upgraded to 
commons-collections4. So the https://github.com/apache/flink/pull/21442 can be 
resolved. And it will remove all the old commons-collections from flink-side.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to