X-czh commented on code in PR #23506:
URL: https://github.com/apache/flink/pull/23506#discussion_r1354793003


##########
flink-core/src/main/java/org/apache/flink/configuration/HighAvailabilityOptions.java:
##########
@@ -167,6 +167,8 @@ public class HighAvailabilityOptions {
                     .withDescription(
                             "Defines the number of connection retries before 
the client gives up.");
 
+    /** @deprecated Don't use this option anymore. It has no effect on Flink. 
*/
+    @Deprecated
     
@Documentation.Section(Documentation.Sections.EXPERT_ZOOKEEPER_HIGH_AVAILABILITY)
     public static final ConfigOption<String> 
ZOOKEEPER_RUNNING_JOB_REGISTRY_PATH =

Review Comment:
   I think we'd better generate docs for deprecated options as well to offer 
proper upgrading guidance in the doc, otherwise users have to either carefully 
read the release notes or to directly look up the source code. I've created a 
JIRA to track this: https://issues.apache.org/jira/browse/FLINK-33240. Maybe we 
can work on that issue first, and come back to this one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to