zentol commented on code in PR #23491:
URL: https://github.com/apache/flink/pull/23491#discussion_r1356745320
##########
flink-architecture-tests/flink-architecture-tests-base/src/main/java/org/apache/flink/architecture/common/Predicates.java:
##########
@@ -62,40 +68,42 @@ public static DescribedPredicate<JavaClass>
containAnyFieldsInClassHierarchyThat
}
/**
- * Tests that the given field is {@code public static} and of the given
type {@code clazz} .
+ * Tests that the given field is {@code public static} and has the fully
qualified type name of
+ * {@code fqClassName}.
*
* <p>Attention: changing the description will add a rule into the
stored.rules.
*/
- public static DescribedPredicate<JavaField> arePublicStaticOfType(Class<?>
clazz) {
Review Comment:
> What do think, could checking out all the connector repos in the main
Flink CI run work for us?
I think we just to clarify what is part of the user (connector?) facing API,
annotate them accordingly, and them treat them as other public APIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
