libenchao commented on code in PR #23478:
URL: https://github.com/apache/flink/pull/23478#discussion_r1358160544
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala:
##########
@@ -488,6 +488,18 @@ object ScalarOperatorGens {
else if (isNumeric(left.resultType) && isNumeric(right.resultType)) {
generateComparison(ctx, "!=", left, right, resultType)
}
+ // support date/time/timestamp not equalTo string.
+ else if (
+ (isTimePoint(left.resultType) && isCharacterString(right.resultType)) ||
Review Comment:
This is an interesting idea, I like it.
I'm not sure about why this is designed to have a dedicated method
originally, I'm guessing that maybe it can directly translate to `left !=
right` which may have slight better performance than `!(left == right)`, and
will be more complex considering null handling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
