[
https://issues.apache.org/jira/browse/FLINK-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ted Yu resolved FLINK-4938.
---------------------------
Resolution: Not A Problem
> Unnecessary update() call for Views to be removed in ViewUpdater#run()
> ----------------------------------------------------------------------
>
> Key: FLINK-4938
> URL: https://issues.apache.org/jira/browse/FLINK-4938
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
>
> {code}
> for (View toUpdate : this.views) {
> toUpdate.update();
> }
> synchronized (lock) {
> views.addAll(toAdd);
> toAdd.clear();
> views.removeAll(toRemove);
> {code}
> For View's in toRemove, update() call is not needed. See earlier javadoc:
> {code}
> * Notifies this ViewUpdater of a metric that should no longer be regularly
> updated.
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
