echauchot commented on code in PR #22985:
URL: https://github.com/apache/flink/pull/22985#discussion_r1360721374
##########
flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/adaptive/ExecutingTest.java:
##########
@@ -594,8 +683,12 @@ public FailureResult howToHandleFailure(Throwable failure)
{
}
@Override
- public boolean shouldRescale(ExecutionGraph executionGraph) {
- return canScaleUp.get();
+ public boolean shouldRescale(ExecutionGraph executionGraph, boolean
forceRescale) {
+ if (forceRescale) {
+ return canScaleUpWithForce;
+ } else {
+ return canScaleUpWithoutForce;
Review Comment:
I was trying to stick to nullable as in the production code and also because
in some tests we don't care about forcing value. But yes I can definitely move
to boolean instead of Boolean to avoid NPE when unboxing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
