yigress commented on code in PR #23425:
URL: https://github.com/apache/flink/pull/23425#discussion_r1361552392
##########
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointsCleaner.java:
##########
@@ -73,8 +83,12 @@ public void cleanCheckpoint(
Executor executor) {
Checkpoint.DiscardObject discardObject =
shouldDiscard ? checkpoint.markAsDiscarded() :
Checkpoint.NOOP_DISCARD_OBJECT;
-
- cleanup(checkpoint, discardObject::discard, postCleanAction, executor);
+ LOG.debug("Clean checkpoint {} fast-mode={}",
checkpoint.getCheckpointID(), parallelMode);
+ if (parallelMode) {
+ cleanup(checkpoint, () -> discardObject.discard(executor),
postCleanAction, executor);
Review Comment:
Yes it did feel awkward to have 2 level of async. updated. please review
again @pnowojski, thank you very much for the review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
