Jiabao-Sun commented on PR #23515: URL: https://github.com/apache/flink/pull/23515#issuecomment-1766518801
> Sorry for not checking it earlier, but the same issue can happen in `testCancelExecutionInNonInteractiveMode`. So, we could provide a fix to there as well. Thanks @XComp, but I don't think this issue can happen in `testCancelExecutionInNonInteractiveMode` because the `CliClient.closed()` method will be called until the newly thread was terminated. Therefore, there is no race condition in this case. WDYT? https://github.com/apache/flink/blob/a29a320187a45ca2579a4cdeddeb99a974d9cf2d/flink-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientTest.java#L273-L279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
