Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2355#discussion_r86749516
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/windows/TimeWindow.java
 ---
    @@ -236,6 +236,6 @@ public int compare(TimeWindow o1, TimeWindow o2) {
         * @return window start
         */
        public static long getWindowStartWithOffset(long timestamp, long 
offset, long windowSize) {
    --- End diff --
    
    In case of sliding windows we have to pass the slide here, yes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to